Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor condition in clusterpolicy and nvidiadriver controller #1172

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

googs1025
Copy link
Contributor

No description provided.

Copy link

copy-pr-bot bot commented Dec 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tariq1890
Copy link
Contributor

/ok-to-test

tariq1890
tariq1890 previously approved these changes Feb 5, 2025
internal/conditions/clusterpolicy.go Outdated Show resolved Hide resolved
internal/conditions/clusterpolicy.go Outdated Show resolved Hide resolved
internal/conditions/nvidiadriver.go Outdated Show resolved Hide resolved
@googs1025 googs1025 force-pushed the refector/conditions branch from 23f4881 to e65a3ef Compare February 6, 2025 01:41
@tariq1890 tariq1890 dismissed their stale review February 6, 2025 02:58

one more comment

Signed-off-by: googs1025 <googs1025@gmail.com>
@googs1025 googs1025 force-pushed the refector/conditions branch from e65a3ef to 97f8b7a Compare February 6, 2025 03:07
@tariq1890
Copy link
Contributor

/ok-to-test

@cdesiniotis cdesiniotis merged commit a7f7fe4 into NVIDIA:main Feb 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants